Removed Log4net and use LibLog for logging #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…soft.Json Changed Tests to use XUnit, Shoudly and NSubstitute
|
Sweet, Thanks. But why did you update the Readme.md? |
|
Opps sorry, thats not an intentional change |
|
Ok. I'll merge it later this weekend. Thanks. |
|
Excellent, look forward to it thanks |
|
Hi. I Reverted to NUnit and the readme file, Everything else is merged :) Thanks for your pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort of Addresses #10 by swapping to LibLog
from the hard reference to log4net.
Have also updated to the nicer testing syntax of Xunit, NSubstitute and Shouldly