Add header, hyperlink and subtext utilities
#6102
Merged
+67
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Category: Core - API - Utils Package
|
The chance is big that Discord.py will add these to their library, however I'm not opposed to merging this. |
That's unlikely, discord.py doesn't have utilities for constructing Markdown since most of the time it's trivial to just do it yourself, often shorter. Our whole chat_formatting module is proof of d.py not having such utilities. |
Jackenmen
added
Type: Feature
|
Probably should be updated to also include Subtext 😅 |
Kowlin
added
Status: Accepted
Kreusada
changed the title
header and hyperlink utilitiesheader, hyperlink and subtext utilities
Good idea. I've just updated the PR to include this 👍 |
Kowlin
approved these changes
Sep 1, 2024
red-githubbot
bot
added
the
Changelog Entry: Pending
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Sep 1, 2024
…#19) Co-authored-by: Kreusada <[email protected]> Co-authored-by: Kowlin <[email protected]>
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Sep 1, 2024
* [Trivia] Correct Stephen to Steven (Cog-Creators#6434) Co-authored-by: Artemis6969 <[email protected]> * Generate default LL server config and attach it to GH release (Cog-Creators#6430) * [Audio] Update Lavalink.jar and yt source build numbers (Cog-Creators#6435) Co-authored-by: Jakub Kuczys <[email protected]> * [Audio] Fix trying to send notify message with no channel object (Cog-Creators#6429) * Bump dependencies (Cog-Creators#6436) * Red 3.5.13 - Changelog (Cog-Creators#6437) * Automated Crowdin downstream (Cog-Creators#6439) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Version bump to 3.5.13 (Cog-Creators#6438) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix publish release workflow * Add missing perm to Publish Release workflow * Change Red 3.5.13 release date * Version bump to 3.5.14.dev1 * [Trivia] Correct typos in World Cup trivia list for Golden Glove questions (Cog-Creators#6441) * Split out non-Python assets in Publish Release workflow (Cog-Creators#6440) * Add `header`, `hyperlink` and `subtext` utilities (Cog-Creators#6102) (#19) Co-authored-by: Kreusada <[email protected]> Co-authored-by: Kowlin <[email protected]> --------- Co-authored-by: Guyonsteroids <[email protected]> Co-authored-by: Artemis6969 <[email protected]> Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: aikaterna <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mellow <[email protected]> Co-authored-by: Kreusada <[email protected]> Co-authored-by: Kowlin <[email protected]>
Dav-Git
pushed a commit
to Dav-Git/Red-DiscordBot
that referenced
this pull request
Sep 8, 2024
Co-authored-by: Kowlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Adds new
headerandhyperlinkutilities, showcased here.Their implementation could be up for discussion if anyone has alternative ideas. I could also add a bullet point util to this PR, but I held back due to not knowing how to best implement embedded bullets.
Have the changes in this PR been tested?
Yes