Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ProcessType in macOS auto-restart service to 'interactive' #6416

Conversation

Jackenmen
Copy link
Member

Description of the changes

This should help with audio stuttering that some users experienced only when using macOS auto-restart service but not when using it interactively.

Relevant documentation:

If [ProcessType is] left unspecified, the system will apply light resource limits to the job, throttling its CPU usage and I/O bandwidth.
[...]
Interactive jobs run with the same resource limitations as apps, that is to say, none. Interactive jobs are critical to maintaining a responsive user experience, and this key should only be used if an app's ability to be responsive depends on it, and cannot be made Adaptive.

Have the changes in this PR been tested?

No

I did not test these changes but they appeared to help at least one person in our support server.

@Jackenmen Jackenmen added the Type: Enhancement Something meant to enhance existing Red features. label Aug 3, 2024
@Jackenmen Jackenmen added this to the 3.5.11 milestone Aug 3, 2024
@github-actions github-actions bot added Category: Docs - Install Guides This is related to install guides. Docs-only labels Aug 3, 2024
@aikaterna aikaterna merged commit 2c2080d into Cog-Creators:V3/develop Aug 4, 2024
18 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Aug 4, 2024
@Jackenmen Jackenmen deleted the macos_launchd_interactive_processtype branch August 4, 2024 19:23
BenCos17 added a commit to JARVIS-discordbot/Red-DiscordBot-jarvis that referenced this pull request Aug 4, 2024
* Set ProcessType in macOS auto-restart service to 'interactive' (Cog-Creators#6416)

* Forcefully shutdown RPC to prevent hangs (Cog-Creators#6412)

* Bump YT source plugin version to 1.5.1 and add custom plugin config (Cog-Creators#6415)

---------

Co-authored-by: Jakub Kuczys <[email protected]>
Co-authored-by: Kowlin <[email protected]>
@Jackenmen Jackenmen modified the milestones: 3.5.12, 3.5.11 Aug 4, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Aug 4, 2024
BenCos17 added a commit to JARVIS-discordbot/Red-DiscordBot-jarvis that referenced this pull request Aug 4, 2024
* Set ProcessType in macOS auto-restart service to 'interactive' (Cog-Creators#6416)

* Forcefully shutdown RPC to prevent hangs (Cog-Creators#6412)

* Bump YT source plugin version to 1.5.1 and add custom plugin config (Cog-Creators#6415)

* Fix unmuting when a mod isn't a mod anymore. (Cog-Creators#6411)

Co-authored-by: TrustyJAID <[email protected]>

* Bump dependencies (Cog-Creators#6417)

* Red 3.5.11 - Changelog (Cog-Creators#6418)

* Automated Crowdin downstream (Cog-Creators#6420)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Version bump to 3.5.11 (Cog-Creators#6419)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jakub Kuczys <[email protected]>

* Version bump to 3.5.12.dev1 (Cog-Creators#6421)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Jakub Kuczys <[email protected]>
Co-authored-by: Kowlin <[email protected]>
Co-authored-by: TrustyJAID <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Docs - Install Guides This is related to install guides. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Docs-only Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants