Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.0.0 rest refactor #69

Merged
merged 34 commits into from
May 30, 2022
Merged

V2.0.0 rest refactor #69

merged 34 commits into from
May 30, 2022

Conversation

lcsmuller
Copy link
Collaborator

What?

  1. Add a per-client thread for managing REST logic.
  2. Allow client to completely idle while not doing anything.

Why?

  1. Add a per-client thread for managing REST logic.
    1.1. Asynchronous requests logic would get entangled with Discord's Gateway loop, meaning performing asynchronous requests were only be possible while discord_run() is performing.
    1.2. Use the same implementation for both asynchronous and synchronous requests - rather than having repetitive code for handling each mode individually.
  2. Reduce the CPU cost of having to unnecessarily iterate the Concord's event-loop if it does not have any pending events.

How?

  1. By using the threadpool from threadpool.h to start a single REST manager thread.
  2. Wake-up the Concord's loop when the heartbeat (ping) interval has been reached.

Testing?

  1. Has been tested for memory leaks and OOB by leaving a test/racecond.c bot spamming.

Anything Else?

This PR will make implementing a solution for #35 far more trivial, considering there is no longer a dependency on the Discord's Gateway running.

lcsmuller and others added 30 commits May 20, 2022 15:43
@lcsmuller
wip(discord-rest): moving logic to a special REST management thread
7096f91
@Anotra
refactor(discord-rest): add io_poller for REST loop
1e5c24c
@Anotra
refactor(discord-internal.h): move discord_timer declarations
4e6a506
@Anotra
refactor(discord-timers): move discord_timers_get_next_trigger to dis…
d7dece5 
…cord_timer.c
@Anotra
refactor(discord-rest) add timer queue to discord REST thread
d721c81
@Anotra
refactor(discord-timer): clean up init and cleanup functions in order…
a06dbc5 
… to be more adaptable
@lcsmuller
wip(discord-rest): triggers pthread_cond_signal() when request is done
3c8e3f5
@Anotra
feat(io_poller): add io_poller_wakeup
612f01e
@Anotra
refactor(discord-rest_async.c): remove useless enable_perform calls, …
5777a1e 
…and add wakeup for io_poller
@Anotra
refactor(discord-rest.c): increase poll time to 60 seconds
02a0d91
@lcsmuller
refactor(discord-rest): move REST io_poller to 'struct discord_async'…
0ed9322 
…; rename idle_contexts to queues->recycling and add queues->completed
@Anotra
fix(io_poller.c): double free in io_poller_create
44d8e14
@Anotra
fix(discord-rest.c): restore discord_rest_async_perform call
4903af4
@Anotra
refactor(discord-rest.c): make shutting down REST thread possible
8663db7
@lcsmuller
V2.0.0 rest refactor wip (#67)
dec0e0a 
* wip(discord-rest): move bucket's pthread_cond_t to individual 'struct discord_context'

* fix(discord-rest_async.c): move io_poller_wakeup() back to discord_async_start_context()
@lcsmuller
wip(discord-rest): finished requests queue that should trigger callba…
0d4b39e 
…cks from the main thread
@lcsmuller
refactor(discord-rest): ensure buckets are only handled from the REST…
f426417 
… thread, modularize and split functions
@lcsmuller
refactor(discord-rest): tidy up codebase by moving functions and structs
8f3359f 
to their appropriate 'discord-rest' module
* fix(discord-rest): race-conditions from cleanup ordering
@lcsmuller
refactor: replace 'discord_request' references with 'discord_attributes'
79c0393
@lcsmuller
refactor(discord-rest): rename discord-rest_async.c ->
ec8d5ad 
discord-rest_request.c
* refactor(discord-rest_request): rename 'struct discord_async' -> 'struct
  discord_requestor', 'struct discord_request' -> 'struct
  discord_request', 'struct discord_context' -> 'struct
  discord_request'
* refactor(discord-rest_request): move every discord-rest.c logic that handles any
  of the discord-rest_request.c structures
@lcsmuller
refactor: move 'struct discord_ratelimiter' field to 'struct discord_…
22ddd81 
…requestor'
@lcsmuller
refactor(discord-rest): move io_poller from 'struct discord_requestor…
1845d53 
…' to 'struct discord_rest'
@lcsmuller
fix(discord-rest): field initialization ordering
5e4996b
@lcsmuller
fix(discord-rest): move discord_request_dispatch_responses() outside …
f6ecf3f 
…of 1sec enforced delay block, add wakeup to main thread's poll
@lcsmuller
refactor(discord-refcount.c): add locks and make discord_refcounter_c…
95c1277 
…ontains() private
@lcsmuller
fix(discord-rest_request.c): lock queues that interface between REST …
3e5081a 
…and separate threads
@lcsmuller
refactor(discord-rest_ratelimit.c): remove all ratelimiting-specific …
f1f1b85 
…mutexes, no longer needed since its only run at the REST thread
@lcsmuller
fix(discord-rest_request): add missing recycling queue lock
6029e6d
@lcsmuller
fix(discord-rest_request): no need to lock entire code chunk once que…
9b34c9c 
…ue has been moved
@Anotra
refactor(discord_gateway): use timer to determine when the next ping is
3692562
@lcsmuller lcsmuller added the enhancement New feature or request label May 30, 2022
@lcsmuller lcsmuller merged commit c9e0b32 into v2.0.0 May 30, 2022
@lcsmuller lcsmuller deleted the v2.0.0-rest_refactor branch May 30, 2022 02:04
@lcsmuller lcsmuller mentioned this pull request May 30, 2022
Closed
@lcsmuller lcsmuller mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcsmuller @Anotra