Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notes and Controls for BSI SYS.1.6.A5 - A9 #12247

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sluetze
Copy link
Contributor

@sluetze sluetze commented Jul 31, 2024

Description:

Notes / Rules for BSI APP4.4.A19

Rationale:

Rationale:

As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.

Fixes

Review Hints:

nothing special here, we don't have new rules. We only link some already existing ones and add descriptions.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 31, 2024
Copy link

openshift-ci bot commented Jul 31, 2024

Hi @sluetze. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@sluetze sluetze changed the title Sys 1 6 a5 Add Notes and Controls for BSI SYS.1.6.A5 - A9 Jul 31, 2024
Copy link

github-actions bot commented Jul 31, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12247
This image was built from commit: f727f10

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12247

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12247 make deploy-local

@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Aug 1, 2024
corresponding consequences for the application run therein. The results of the checking
(1) An application or service to be operated in a container SHOULD be suitable for such operation.
(2) It SHOULD be considered that containers can often be terminated unexpectedly, with
corresponding consequences for the application run therein. (3) The results of the checking
described under SYS.1.6.A3 Secure Use of Containerised IT Systems SHOULD be documented in
Copy link
Collaborator

@BhargaviGudi BhargaviGudi Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could not understand the line (3) The results of the checking described under SYS.1.6.A3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

this is the original content of BSI which loses a bit of meaning by removing the italics here.

so basically it would be

The results of the checking described under SYS.1.6.A3: "Secure Use of Containerised IT Systems" SHOULD be documented in a comprehensible manner.

I could add the quotation like above to make it more understandable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sluetze I think the quotation marks will help here.
But I don't consider this critical.

Copy link

codeclimate bot commented Aug 20, 2024

Code Climate has analyzed commit f727f10 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato self-assigned this Sep 17, 2024
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

corresponding consequences for the application run therein. The results of the checking
(1) An application or service to be operated in a container SHOULD be suitable for such operation.
(2) It SHOULD be considered that containers can often be terminated unexpectedly, with
corresponding consequences for the application run therein. (3) The results of the checking
described under SYS.1.6.A3 Secure Use of Containerised IT Systems SHOULD be documented in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sluetze I think the quotation marks will help here.
But I don't consider this critical.

@yuumasato yuumasato added this to the 0.1.75 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants