Improve file extensions #963
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template file extensions were always kind of weird, and i know they're arbitrary, but it just makes more sense to follow some pattern, thats why the whole
*config.jsonand*metaconfig.jsonstuff happened in the first place. However, the current way without any delimiter, makes it harder to programmatically go over the different config types (*metaconfig.jsonalso contains*config.json, y know) and it's generally just harder to read when you look over a repo and see thisI would suggest; for the future atleast, you enforce such a naming scheme for Pull Requests that want to be merged into the official template repo