Fix TinyMCE-Related Console Warnings #3425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, `Invalid value passed for the forced_root_block option. Must be a non-empty string.` would be rendered as a console warning. - This commit removes the console warning, but it shouldn't have an effect on the app's behaviour. Even when `forced_root_block: ''` existed, the entries would be saved with <p></p> tags surrounding them. (Documented here: #3424 (comment) )
Prior to this change,`tinymceEditor.settings` was evaluating to `undefined`. Also, TinyMCE replaced `autoresize_min_height` replaced with `min_height` with the release of v5. We have `min_height` included in our defaultOptions object within `app/javascript/src/utils/tinymce.js`. The value of `min_height` appears to be performing the functionality that this removed code was attempting to. This change is more comprehensively documented here: #3424 (comment)
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3424
Changes proposed in this PR:
forced_root_block: ''fromapp/javascript/src/superAdmin/notifications/edit.jsThe [forced_root_block](https://www.tiny.cloud/docs/tinymce/5/content-filtering/#forced_root_block) option will no-longer accept the false value or an empty string value in TinyMCE 6.0https://www.tiny.cloud/docs/tinymce/5/6.0-upcoming-changes/app/javascript/src/utils/conditionalFields.jstinymceEditor.settings.autoresize_min_height. However,tinymceEditor.settings.was evaluating toundefined. In addition, TinyMCE replacedautoresize_min_heightwithmin_heightwhen it upgraded from v4 to v5 (https://www.tiny.cloud/blog/how-to-migrate-from-tinymce-4-to-tinymce-5/).min_height:, within the thedefaultOptionsobject ofapp/javascript/src/utils/tinymce.js(documented here: TinyMCE Related Console Warnings #3424 (comment)).