Skip to content

Commit

Permalink
ethdev: add packet type matching item
Browse files Browse the repository at this point in the history
Add RTE_FLOW_ITEM_TYPE_PTYPE to allow matching on
L2/L3/L4 and tunnel information as defined in mbuf.

To match on RTE_PTYPE_L4_TCP and RTE_PTYPE_INNER_L4_UDP:
  flow pattern_template 0 create pattern_template_id 1
    ingress template ptype packet_type mask 0x0f000f00 / end
  flow queue 0 create 0 template_table 1
    pattern_template 0 actions_template 0
    pattern ptype packet_type is 0x02000100 / end
    actions queue index 1 / end

Signed-off-by: Alexander Kozyrev <[email protected]>
Acked-by: Ori Kam <[email protected]>
  • Loading branch information
aleks-kozyrev authored and ferruhy committed Oct 10, 2023
1 parent 63ce6cb commit 0ddff06
Show file tree
Hide file tree
Showing 6 changed files with 66 additions and 0 deletions.
28 changes: 28 additions & 0 deletions app/test-pmd/cmdline_flow.c
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,8 @@ enum index {
ITEM_IB_BTH_PSN,
ITEM_IPV6_PUSH_REMOVE_EXT,
ITEM_IPV6_PUSH_REMOVE_EXT_TYPE,
ITEM_PTYPE,
ITEM_PTYPE_VALUE,

/* Validate/create actions. */
ACTIONS,
Expand Down Expand Up @@ -1578,6 +1580,7 @@ static const enum index next_item[] = {
ITEM_AGGR_AFFINITY,
ITEM_TX_QUEUE,
ITEM_IB_BTH,
ITEM_PTYPE,
END_SET,
ZERO,
};
Expand Down Expand Up @@ -2097,6 +2100,12 @@ static const enum index item_ib_bth[] = {
ZERO,
};

static const enum index item_ptype[] = {
ITEM_PTYPE_VALUE,
ITEM_NEXT,
ZERO,
};

static const enum index next_action[] = {
ACTION_END,
ACTION_VOID,
Expand Down Expand Up @@ -5896,6 +5905,22 @@ static const struct token token_list[] = {
.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ib_bth,
hdr.psn)),
},
[ITEM_PTYPE] = {
.name = "ptype",
.help = "match L2/L3/L4 and tunnel information",
.priv = PRIV_ITEM(PTYPE,
sizeof(struct rte_flow_item_ptype)),
.next = NEXT(item_ptype),
.call = parse_vc,
},
[ITEM_PTYPE_VALUE] = {
.name = "packet_type",
.help = "packet type as defined in rte_mbuf_ptype",
.next = NEXT(item_ptype, NEXT_ENTRY(COMMON_UNSIGNED),
item_param),
.args = ARGS(ARGS_ENTRY(struct rte_flow_item_ptype, packet_type)),
},

/* Validate/create actions. */
[ACTIONS] = {
.name = "actions",
Expand Down Expand Up @@ -12810,6 +12835,9 @@ flow_item_default_mask(const struct rte_flow_item *item)
case RTE_FLOW_ITEM_TYPE_IB_BTH:
mask = &rte_flow_item_ib_bth_mask;
break;
case RTE_FLOW_ITEM_TYPE_PTYPE:
mask = &rte_flow_item_ptype_mask;
break;
default:
break;
}
Expand Down
1 change: 1 addition & 0 deletions doc/guides/nics/features/default.ini
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ ppp =
pppoed =
pppoes =
pppoe_proto_id =
ptype =
quota =
raw =
represented_port =
Expand Down
7 changes: 7 additions & 0 deletions doc/guides/prog_guide/rte_flow.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1566,6 +1566,13 @@ Matches an InfiniBand base transport header in RoCE packet.

- ``hdr``: InfiniBand base transport header definition (``rte_ib.h``).

Item: ``PTYPE``
^^^^^^^^^^^^^^^

Matches the packet type as defined in rte_mbuf_ptype.

- ``packet_type``: L2/L3/L4 and tunnel information.

Actions
~~~~~~~

Expand Down
4 changes: 4 additions & 0 deletions doc/guides/testpmd_app_ug/testpmd_funcs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3815,6 +3815,10 @@ This section lists supported pattern items and their attributes, if any.

- ``send_to_kernel``: send packets to kernel.

- ``ptype``: match the packet type (L2/L3/L4 and tunnel information).

- ``packet_type {unsigned}``: packet type.


Actions list
^^^^^^^^^^^^
Expand Down
1 change: 1 addition & 0 deletions lib/ethdev/rte_flow.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ static const struct rte_flow_desc_data rte_flow_desc_item[] = {
MK_FLOW_ITEM(AGGR_AFFINITY, sizeof(struct rte_flow_item_aggr_affinity)),
MK_FLOW_ITEM(TX_QUEUE, sizeof(struct rte_flow_item_tx_queue)),
MK_FLOW_ITEM(IB_BTH, sizeof(struct rte_flow_item_ib_bth)),
MK_FLOW_ITEM(PTYPE, sizeof(struct rte_flow_item_ptype)),
};

/** Generate flow_action[] entry. */
Expand Down
25 changes: 25 additions & 0 deletions lib/ethdev/rte_flow.h
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,14 @@ enum rte_flow_item_type {
* @see struct rte_flow_item_ib_bth.
*/
RTE_FLOW_ITEM_TYPE_IB_BTH,

/**
* Matches the packet type as defined in rte_mbuf_ptype.
*
* See struct rte_flow_item_ptype.
*
*/
RTE_FLOW_ITEM_TYPE_PTYPE,
};

/**
Expand Down Expand Up @@ -2309,6 +2317,23 @@ static const struct rte_flow_item_tx_queue rte_flow_item_tx_queue_mask = {
};
#endif

/**
*
* RTE_FLOW_ITEM_TYPE_PTYPE
*
* Matches the packet type as defined in rte_mbuf_ptype.
*/
struct rte_flow_item_ptype {
uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
};

/** Default mask for RTE_FLOW_ITEM_TYPE_PTYPE. */
#ifndef __cplusplus
static const struct rte_flow_item_ptype rte_flow_item_ptype_mask = {
.packet_type = 0xffffffff,
};
#endif

/**
* Action types.
*
Expand Down

0 comments on commit 0ddff06

Please sign in to comment.