Reading Username and Password from environment to enable scripting #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dadoum
requested changes
Apr 23, 2024
| if (!interactive) { | ||
| string appleId = environment.get("APPLE_ID_USER"); | ||
| string password = environment.get("APPLE_ID_PWD"); | ||
| if(interactive && (appleId is null || password is null)) { |
There was a problem hiding this comment.
I would probably do an interactive || here, as if the interactive switch is given it's probably to make the prompt appear.
There was a problem hiding this comment.
I think && is the better choice, as we want the prompt only in interactive mode - if there is no interactive mode, don't prompt, but fail - otherwise you'd receive a prompt in an non-interactive session.
For my use case I want to use this in an autonomous scripting scenario - failing in case input is required is exactly what I want :D
|
Otherwise your code is well-made |
Dadoum
force-pushed
the
main
branch
2 times, most recently
from
c544aab
to
77d51fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the option to specify
APPLE_ID_USERandAPPLE_ID_PWDin the environment, to run this script non-interactively.Fails if MFA is required non-interactively.
This is my first time touching D-lang - please let me know if this is not how it should be done :D