Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] skip flaky tests (APMAPI-724) #3071

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

cbeauchesne
Copy link
Collaborator

Motivation

he probable cause is that some dsm endpoints hangs randomly hangs for more than 5s. When the scenario does not fails, those endpoints takes few ms, but I didn’t succed to figure out what’s happening

Changes

  • skip those test
  • also, activate two easy wins.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne changed the title [python] skip falky tests (APMAPI-724) [python] skip flaky tests (APMAPI-724) Sep 19, 2024
@cbeauchesne cbeauchesne marked this pull request as ready for review September 19, 2024 13:07
@cbeauchesne cbeauchesne requested a review from a team as a code owner September 19, 2024 13:07
@cbeauchesne cbeauchesne merged commit f8d8360 into main Sep 19, 2024
36 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/APMAPI-724 branch September 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants