Khanayan123/implement dd trace agent url system test #3073
Conversation
khanayan123
force-pushed
the
khanayan123/implement_dd_trace_agent_url_system_test
branch
from
a1802d9
to
afedfdf
Compare
khanayan123
requested review from
romainkomorndatadog,
manuel-alvarez-alvarez,
jandro996 and
cataphract
and removed request for
a team
Co-authored-by: Zach Montoya <[email protected]>
Co-authored-by: Zach Montoya <[email protected]>
manifests/cpp.yml
Outdated
| @@ -137,6 +137,7 @@ tests/: | |||
| Test_Dsm_Manual_Checkpoint_Intra_Process: missing_feature | |||
| parametric/: | |||
| test_config_consistency.py: | |||
| Test_Config_DDTraceAgentURL: missing_feature | |||
There was a problem hiding this comment.
Do we need to set this to missing_feature? Can we just get this test to pass in this PR OR leave a descriptive message on why this test is failing (ex: missing_feauture (cpp does not support uds)
There was a problem hiding this comment.
You don't necessarily need to give a reason for missing_feature, but it may help later on, so if you have one that is not as obvious as "we didn't started yet to work on this" , feel free to add it.
There was a problem hiding this comment.
@mabdinur setting it to missing_feature as of now because the parametric client apps need to be updated to send dd_trace_agent_url
| assert ( | ||
| True | ||
| ), "wait_for_num_traces raises an exception after waiting for 1 trace." # wait_for_num_traces will throw an error if not received within 2 sec, so we expect to see an exception |
There was a problem hiding this comment.
You don't need this assertion. If a ValueError is not raised on line 141 then this test will fail. If you want to add an assertion you can check the error message in the value error and ensure it's do to a timeout/missing spans and not some other failure.
| assert ( | |
| True | |
| ), "wait_for_num_traces raises an exception after waiting for 1 trace." # wait_for_num_traces will throw an error if not received within 2 sec, so we expect to see an exception |
| assert ( | ||
| True | ||
| ), "wait_for_num_traces raises an exception after waiting for 1 trace." # wait_for_num_traces will throw an error if not received within 2 sec, so we expect to see an exception |
manifests/cpp.yml
Outdated
| @@ -137,6 +137,7 @@ tests/: | |||
| Test_Dsm_Manual_Checkpoint_Intra_Process: missing_feature | |||
| parametric/: | |||
| test_config_consistency.py: | |||
| Test_Config_DDTraceAgentURL: missing_feature | |||
There was a problem hiding this comment.
Typo in naming:
| Test_Config_DDTraceAgentURL: missing_feature | |
| Test_Config_TraceAgentURL: missing_feature |
manifests/nodejs.yml
Outdated
| @@ -517,6 +517,7 @@ tests/: | |||
| TestAdmisionControllerProfiling: *ref_5_22_0 | |||
| parametric/: | |||
| test_config_consistency.py: | |||
| Test_Config_DDTraceAgentURL: *ref_5_23_0 | |||
There was a problem hiding this comment.
was this feature just merged to master ? this version hasn't been released yet
Motivation
config consistency initiative
Changes
implement dd trace agent url system test