Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static analysis rules for Java #3074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smola
Copy link
Member

@smola smola commented Sep 19, 2024

Motivation

Ignore security violations in Java test applications. These applications are meant to be vulnerable for our own testing logic, so there's no point in being warned about it.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@smola smola requested a review from a team as a code owner September 19, 2024 15:33
@smola smola force-pushed the smola/datadog-static-analysis branch from 2991b74 to 5493d3b Compare September 20, 2024 06:12
@cbeauchesne
Copy link
Collaborator

If i'm not wrong, I've unsubscribed from static analysis, no ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants