Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stub fedora installer tests #3077

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

stub fedora installer tests #3077

wants to merge 3 commits into from
+75 −21

Conversation

emmettbutler
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@emmettbutler emmettbutler requested a review from a team as a code owner September 19, 2024 21:06
@emmettbutler emmettbutler marked this pull request as draft September 19, 2024 21:06
robertomonteromiguel
robertomonteromiguel reviewed Sep 20, 2024
View reviewed changes
utils/_context/virtual_machines.py Outdated
def __init__(sef, **kwargs) -> None:
super().__init__(
"Fedora_39_amd64",
aws_config=_AWSConfig(ami_id="ami-0ba8f2988373d0735", ami_instance_type="t2.medium", user="fedora"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are using the worng AMI id. See this message running the tests:
06:21:01.786 INFO Diagnostics: 06:21:01.786 INFO aws:ec2:Instance (Fedora_39_amd64): 06:21:01.786 INFO error: 1 error occurred: 06:21:01.786 INFO * creating EC2 Instance: OptInRequired: In order to use this AWS Marketplace product you need to accept terms and subscribe. To do so please visit https://aws.amazon.com/marketplace/pp?sku=ec8t8q98ms0b0idcq74tlco2a 06:21:01.786 INFO status code: 401, request id: 23227fff-a900-4042-8dfa-426554cecfce 06:21:01.786 INFO 06:21:01.786 INFO pulumi:pulumi:Stack (system-tests-vms-system-tests_onboarding): 06:21:01.786 INFO error: update failed

Pipeline: https://gitlab.ddbuild.io/DataDog/system-tests/-/pipelines/44748391

Try to find the correct ami from: aws console --> ec2 --> images --> amis --> search for public images

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every other AMI I use here gives me this message in the logs

command:remote:Command -Fedora_39_amd64-init-config creating (15s) Dial 1/inf failed: retrying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertomonteromiguel robertomonteromiguel robertomonteromiguel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmettbutler @robertomonteromiguel