#33 refactor method (linting, readability) #180
+94
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warm-coolguy
changed the title
dopenguin
requested changes
Sep 20, 2024
There was a problem hiding this comment.
In the past, we've added information regarding refactorings to the Changelog. I think some relevant entries should be added here as well
🏓 @warm-coolguy
| const mapContext = mapCanvas.getContext('2d') | ||
| if (!mapContext) { | ||
| console.error( | ||
| '@polar/plugin-export: map does not of a 2d context, export failed.' |
There was a problem hiding this comment.
Suggested change
| '@polar/plugin-export: map does not of a 2d context, export failed.' | |
| '@polar/plugin-export: map does not have a 2d context, export failed.' |
Let's fix this while we are at it
| matrix | ||
| ) | ||
| mapContext.drawImage(canvas, 0, 0) | ||
| } else console.warn('@polar/plugin-export: canvas width is 0') |
There was a problem hiding this comment.
Suggested change
| } else console.warn('@polar/plugin-export: canvas width is 0') | |
| } else console.warn('@polar/plugin-export: canvas width is 0.') |
| link.click() | ||
| document.body.removeChild(link) | ||
| } | ||
| if (download) downloadAsImage(src, type) |
There was a problem hiding this comment.
As I can' suggest it (deleted lines and such), here is what I would've anticipated:
if (
(type === ExportFormat.JPG || type === ExportFormat.PNG) &&
download
) {
downloadAsImage(src, type)| jsPdf.addImage(src, 'JPEG', 0, 0, dim[0], dim[1]) | ||
| // Reset original map size | ||
| map.setSize(size) | ||
| map.getView().setResolution(map.getView().getResolution()) |
There was a problem hiding this comment.
There must've been a reason for the variable beforehand. Are you sure, this doesn't change anything? map.getSize() is still set as a variable on the other hand.
Now that I think about it: What happens if neither the size of the map or the resolution is reset?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve readability of export implementation. Remove linting warning.
Instructions for local reproduction and review
Fiddle with export tool in snowbox to check some combinations. Snippet as reminder:
Relevant tickets, issues, et cetera
#33