Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ensure "lanes" tag for railway type is converted to Int8 #93

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

captchanjack
Copy link
Collaborator

@captchanjack captchanjack commented Apr 13, 2023

Fixes parsing issue when dealing with railway networks, this commit will ensure lanes are converted to the required type (Int8)

Should #51

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.21 🎉

Comparison is base (d9dda71) 79.87% compared to head (ac52c93) 80.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   79.87%   80.08%   +0.21%     
==========================================
  Files          14       15       +1     
  Lines        1133     1135       +2     
==========================================
+ Hits          905      909       +4     
+ Misses        228      226       -2     
Impacted Files Coverage Δ
src/parse.jl 89.41% <50.00%> (+0.58%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jarodlam
Copy link
Collaborator

Need to see how this interacts with #90. This PR fixed some logic with how we parse the lanes tag as well, and it might be relevant here

@captchanjack captchanjack merged commit 6442955 into master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants