Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement home timeline reverse chrono #664

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ntorba
Copy link

@ntorba ntorba commented Nov 10, 2022

PR for the feature requested here: #639

Unless I am missing something, the changes I made to the __init__ should allow users to access other v2-only endpoint as well #581

@SamHames
Copy link
Contributor

Thanks for the PR!

Does that actually work for other users timelines? From the documentation I thought that would endpoint would only work for the authenticating user's own timeline?

Would you mind keeping the changes related to #581 separate? I don't really understand the authentication issues to merge this PR with that in. That endpoint should still work fine with the existing user scope credentials.

@SamHames
Copy link
Contributor

@edsu @igorbrigadir - did we merge in some testing code at some point? I'm a bit confused how we ended up with all the test names changed to atest_* so that pytest doesn't pick them up...

@igorbrigadir
Copy link
Contributor

Yeah i'm not sure what happened to the tests either. The reverse chronological timeline does require user context so using @jack in the test will always fail: https://developer.twitter.com/en/docs/twitter-api/tweets/timelines/api-reference/get-users-id-reverse-chronological

Either way, I think it's worth having this because it's hard to get locked (private) accounts otherwise.

@edsu
Copy link
Member

edsu commented Jan 5, 2023

That was my mistake with atest_* that's a dumb hack I sometimes use to just test one thing when I can't be bothered to look up how to do it :-) My apologies!

@igorbrigadir
Copy link
Contributor

I'm gonna fix this one up in a bit too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants