[Proposal] ♻️ Added the ability to go to the floor map from the session details. #1127
Conversation
| class DefaultNavigationRequester : NavigationRequester { | ||
| private val _navigateRequestStateFlow = MutableStateFlow("") | ||
| override fun getNavigationRouteFlow(): Flow<String> = _navigateRequestStateFlow | ||
|
|
||
| override fun navigateTo(route: String) { | ||
| _navigateRequestStateFlow.value = route | ||
| } | ||
|
|
||
| override fun navigated() { | ||
| _navigateRequestStateFlow.value = "" | ||
| } | ||
| } |
There was a problem hiding this comment.
We did this to operate between different NavHosts.
I don't think this is the best way to do it, so if you have a better idea, I'm open to it.
I doubt if the name NavigationRequester is appropriate either.
|
Hi @Corvus400! Codes seem to be unformatted. To resolve this issue, please run |
…ontent_detail' into feature/move_to_floor_map_from_content_detail
| @@ -109,6 +112,10 @@ fun TimetableItemDetailScreen( | |||
| onNavigationIconClick = onNavigationIconClick, | |||
| onBookmarkClick = viewModel::onBookmarkClick, | |||
| onLinkClick = onLinkClick, | |||
| onRoomClick = { | |||
| viewModel.navigateTo("floorMap") | |||
There was a problem hiding this comment.
I would like to change this part if possible since it is directly specified.
It would be helpful if FloorMapScreenRoute could be referenced in this case.
| @@ -111,6 +111,9 @@ private fun KaigiNavHost( | |||
| onTimetableItemClick = navController::navigateToTimetableItemDetailScreen, | |||
| onNavigateToBookmarkScreenRequested = navController::navigateToBookmarkScreen, | |||
| onLinkClick = externalNavController::navigate, | |||
| onRoomClick = { | |||
| navController.popBackStack(navController.graph.startDestinationId, false) | |||
There was a problem hiding this comment.
Well, it's difficult to think but what if we create navController::navigateToMainFloorMapScreen?
I think we can see parent navController to access getBackStackEntry 👀
There was a problem hiding this comment.
Once I was able to return to the start destination with the following code.
fun NavController.navigateToMainFloorMapScreen() {
getBackStackEntry(timetableItemDetailScreenRoute).destination.parent?.startDestinationId?.let {
navigate(it)
// TODO navigateMainFloorMap
}
}However, I have not figured out how to move to FloorMapScreen from here without having to make any major changes.
Do you already have any ideas? 🙇
There was a problem hiding this comment.
I'm not sure about this. But I think we can pass the route parameter to NavHost and we may be able to pass /main/floorMap.
There was a problem hiding this comment.
@takahirom
I have tried the suggested method, but unfortunately the app crashes. 🙇
We still think that as long as NavHost is split into two, it is unfortunately difficult to achieve this functionality other than this current implementation. 🙇
github-actions
bot
temporarily deployed
to
deploygate-distribution
github-actions
bot
temporarily deployed
to
deploygate-distribution
github-actions
bot
temporarily deployed
to
deploygate-distribution
Issue
Overview (Required)
Movie (Optional)
after.mp4