Skip to content

Commit

Permalink
Merge pull request #707 from yuchan2215/profile-scroll
Browse files Browse the repository at this point in the history
Profile card scrollable on small devices
  • Loading branch information
takahirom committed Aug 21, 2024
2 parents b63c493 + 31e6bfb commit ea006d3
Showing 1 changed file with 11 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ internal fun ProfileCardScreen(
AnimatedTextTopAppBar(
colors = TopAppBarDefaults.topAppBarColors(
containerColor = LocalProfileCardTheme.current.primaryColor,
scrolledContainerColor = LocalProfileCardTheme.current.primaryColor,
),
textColor = MaterialTheme.colorScheme.scrim,
title = stringResource(ProfileCardRes.string.profile_card_title),
Expand Down Expand Up @@ -287,6 +288,7 @@ internal fun ProfileCardScreen(
if (uiState.cardUiState == null) return@Scaffold
CardScreen(
uiState = uiState.cardUiState,
scrollBehavior = scrollBehavior,
onClickEdit = {
eventEmitter.tryEmit(CardScreenEvent.Edit)
},
Expand Down Expand Up @@ -655,11 +657,13 @@ fun Modifier.selectedBorder(
this
}

@OptIn(ExperimentalMaterial3Api::class)
@Composable
internal fun CardScreen(
uiState: ProfileCardUiState.Card,
onClickEdit: () -> Unit,
onClickShareProfileCard: (ImageBitmap) -> Unit,
scrollBehavior: TopAppBarScrollBehavior,
modifier: Modifier = Modifier,
isCreated: Boolean = false,
contentPadding: PaddingValues = PaddingValues(16.dp),
Expand All @@ -672,11 +676,15 @@ internal fun CardScreen(
modifier = modifier
.fillMaxSize()
.background(LocalProfileCardTheme.current.primaryColor)
.testTag(ProfileCardCardScreenTestTag)
.padding(contentPadding),
.testTag(ProfileCardCardScreenTestTag),
) {
Column(
modifier = Modifier.fillMaxSize(),
modifier = Modifier
.fillMaxSize()
.nestedScroll(scrollBehavior.nestedScrollConnection)
.verticalScroll(rememberScrollState())
.padding(vertical = 32.dp)
.padding(contentPadding),
horizontalAlignment = Alignment.CenterHorizontally,
verticalArrangement = Arrangement.Center,
) {
Expand Down

0 comments on commit ea006d3

Please sign in to comment.