Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/timetable android day button fixes #184

Merged
merged 9 commits into from
Aug 3, 2024

Conversation

charles-b-stb
Copy link
Contributor

Issue

  • [Android] Tabs for the timetable view were not united between the list and graph view. The graph view tabs were better but did nothing when clicked, the list tabs worked when clicked but looked incorrect.

Overview (Required)

  • Moved the Graph tabs to the top level
  • added the existing list button functionality to the graph tabs.
  • Changed tabs to update text when clicked (matching Figma spec)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After
スクリーンショット 2024-07-31 22 24 48 スクリーンショット 2024-07-31 22 23 25

|

Movie (Optional)

Before After

before_tab_fix.webm | fixedTabsRecording.webm

Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot had a problem deploying to deploygate-distribution July 31, 2024 13:34 Failure
@github-actions github-actions bot had a problem deploying to deploygate-distribution July 31, 2024 14:20 Failure
@charles-b-stb
Copy link
Contributor Author

Does anyone know why this is having a deploy failure?

@takahirom
Copy link
Member

I think it's okay. We just didn't have the proper setup for deployment.

Copy link

github-actions bot commented Aug 3, 2024

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 3, 2024 04:34 Inactive
@takahirom takahirom merged commit b93f0a9 into main Aug 3, 2024
5 checks passed
@takahirom takahirom deleted the feature/timetable-android-day-button-fixes branch August 3, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants