Skip to content

Commit

Permalink
fix: open id issue
Browse files Browse the repository at this point in the history
Signed-off-by: EINDEX <[email protected]>
  • Loading branch information
EINDEX committed Sep 17, 2023
1 parent 741a384 commit d3a7707
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 42 deletions.
43 changes: 4 additions & 39 deletions src/memos/__tests__/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def hello():
relationList: [],
};

const res = memoContentGenerate(memo, "host", "openId", "TODO");
const res = memoContentGenerate(memo, "host", "TODO");
expect(res[0]["content"]).toBe(codeBody);
});

Expand Down Expand Up @@ -61,46 +61,11 @@ def hello():
relationList: [],
};

const res = memoContentGenerate(memo, "host", "openId", "TODO");
const res = memoContentGenerate(memo, "host", "TODO");
expect(res[0].children?.length).toBe(1);
expect(res[0].children![0].content).toBe("![memos.png](host/o/r/1)");
});

it("private resources could rending with openId", () => {
const memo: Memo = {
id: 1,
rowStatus: "NORMAL",
creatorId: 1,
createdTs: 1690045876,
updatedTs: 1690079500,
displayTs: 1690045876,
content: "test",
visibility: "PRIVATE",
pinned: false,
creatorName: "eindex",
creatorUsername: "eindex",
resourceList: [
{
id: 1,
createdTs: 1690079497,
updatedTs: 1690079497,
filename: "memos.png",
externalLink: "",
type: "image/png",
size: 1539508,
linkedMemoAmount: 1,
},
],
relationList: [],
};

const res = memoContentGenerate(memo, "host", "openId", "TODO");
expect(res[0].children?.length).toBe(1);
expect(res[0].children![0].content).toBe(
"![memos.png](host/o/r/1?openId=openId)"
);
});

it("private resources have external link should using external link", () => {
const memo: Memo = {
id: 1,
Expand Down Expand Up @@ -129,7 +94,7 @@ def hello():
relationList: [],
};

const res = memoContentGenerate(memo, "host", "openId", "TODO");
const res = memoContentGenerate(memo, "host", "TODO");
expect(res[0].children?.length).toBe(1);
expect(res[0].children![0].content).toBe("![memos.png](link)");
});
Expand Down Expand Up @@ -162,7 +127,7 @@ def hello():
relationList: [],
};

const res = memoContentGenerate(memo, "host", "openId", "TODO");
const res = memoContentGenerate(memo, "host", "TODO");
expect(res[0].children?.length).toBe(1);
expect(res[0].children![0].content).toBe("![memos.png](link)");
});
Expand Down
3 changes: 0 additions & 3 deletions src/memos/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export const formatContentWhenPush = (content: string) => {
export const memoContentGenerate = (
memo: Memo,
host: string,
openId: string,
preferredTodo: string,
withProperties: boolean = false
): IBatchBlock[] => {
Expand All @@ -43,8 +42,6 @@ export const memoContentGenerate = (
link = resource.externalLink;
}else if(memo.visibility.toLowerCase() == Visibility.Public.toLowerCase()){
link = `${host}/o/r/${resource.id}`;
}else{
link = `${host}/o/r/${resource.id}?openId=${openId}`;
}
children.push({content: `![${resource.filename}](${link})`});
}
Expand Down

0 comments on commit d3a7707

Please sign in to comment.