split up tests #1868
Open
split up tests #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExpandingMan
commented
Sep 20, 2024
ExpandingMan
commented
Sep 20, 2024
ExpandingMan
commented
Sep 20, 2024
| sc = rand(Float32, 6) | ||
| bi = rand(Float32, 6) | ||
| #WARN: this is where there is a segfault that I can't figure out | ||
| #Enzyme.autodiff(Reverse, bc2_loss_function, Active, Duplicated(x, Enzyme.make_zero(x)), |
There was a problem hiding this comment.
I have explicitly confirmed that in isolation bc2_loss_fuction works fine on the provided arguments, but this autodiff segfaults. Becoming more confident this is an enzyme bug. Not sure what was preventing it from segfaulting before this PR.
|
open a mwe issue for each of these? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-do of #1824 for post 0.13.
To reiterate, the goal here is to roughly group the tests by the functionality they are testing and separate them into a large number of files which should be possible to run entirely independently. Again the way I have grouped these tests may not always make a lot of sense, it seems likely they'll get shuffled around more in the future (or before this gets merged) but this seems like a decent start.
There is still a major issue that I've so far been unable to resolve: a setfault in
arrays.jl, which I've seen before when trying to split up the tests. It sure looks to me like the fact that it segfaults is an enzyme bug, as I don't see any reason it should do that, especially merely as a result of being in a different file.As of writing, everything else in here passes as expected for me (x86 linux).