Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Implement agendawidget #780

Closed

Conversation

newhinton
Copy link
Contributor

This is a testimplementation for an simple agendawidget. I based it on the existing widgetcode, which i extended to easily add new/different widgets.

@newhinton
Copy link
Contributor Author

image

@newhinton
Copy link
Contributor Author

newhinton commented Sep 22, 2020

Theming "works" (i need quite a lot of different drawables, because i cant set colors dynamically, gladly i only need the single colors and not combinations of colors and themes)
I needed to make some stuff public from DynamicTheme for that. Loading is a bit buggy, and clicking on a single entry does not open the corresponding event but the App in general.

Code needs heavy cleanup. Also, sometimes events are duplicated. Was that a known issue?

@newhinton
Copy link
Contributor Author

newhinton commented Sep 24, 2020

@Gitsaibot @jspricke So i got it to work stable, so the bare minimum has been achieved. However, i had to touch many parts of the old widget code, and i would suggest that i furter alter it, to create a "generic" widget, that can be used in other widgets.

For example, one "problem" with the existing code is, that it adds the first element twice, presumably to show it as an header. That does not work with my implementation, therefore that needs to be removed. In my dreamimplementation, we have a widgetservice that only supplies the logic to load data and update the widget, while the code associated with displaying lists and creating the actual widget needs to be implemented by smaller widgets.

Are there any plans that would interfere with those changes, or can i continue to strip down the existing code and make it more generic?

Edit: I read #417, and found out that you already reworked the code, as i was wondering why exactly your prefectly fine code was disabled at all :D As i see that we now have two agenda-widgets, i may have to rething what exactly to build with it ^^
There is still #428, so making this more generic seems a good idea to me, but please tell me what you think how this should be done, so that we dont get conflicting implementations :D

@ghost
Copy link

ghost commented Aug 11, 2021

Any update on this?

@ghost
Copy link

ghost commented Oct 21, 2021

I was hoping on a update as well

Any update on this?

@newhinton newhinton changed the title Implement agendawidget [Draft] Implement agendawidget Jan 8, 2022
@newhinton
Copy link
Contributor Author

Closed in favor of #1078

@newhinton newhinton closed this Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant