libINIReader depends on libinih, the order is important when these libraries are static libraries

[leleliu008]

close #2965

[kmilos]

Thanks. Have you maybe tried linking just w/ libINIReader?

[leleliu008]

Thanks. Have you maybe tried linking just w/ libINIReader?

No. just linking libINIReader would arise undefiend symbol when libINIReader is libINIReader.a

[kmilos]

I meant just inih::inireader... That target should already imply the inih::libinih one, so we don't need both, no? Then the problem of ordering simply goes away...

[leleliu008]

inih

I meant just inih::inireader... That target should already imply the inih::libinih one, so we don't need both, no? Then the problem of ordering simply goes away...

No. please read https://github.com/Exiv2/exiv2/blob/main/cmake/Findinih.cmake

[kmilos]

Ah, thanks for that reminder, I thought libinih shipped its own .cmake config files...

We might want to think about fixing Findinih.cmake then, but then there is always the question of what Conan does with its generated one...

[neheb]

is this only relevant for cmake?

[leleliu008]

https://github.com/benhoyt/inih use meson build system. It doesn't install cmake module file but install .pc files.

/Users/fpliu/.ppkg/installed/macos-14.4.1-arm64/inih
├── include
│   ├── INIReader.h
│   └── ini.h
└── lib
    ├── libINIReader.0.dylib
    ├── libINIReader.a
    ├── libINIReader.dylib -> libINIReader.0.dylib
    ├── libinih.0.dylib
    ├── libinih.a
    ├── libinih.dylib -> libinih.0.dylib
    └── pkgconfig
        ├── INIReader.pc
        └── inih.pc

4 directories, 10 files

[kmilos]

is this only relevant for cmake?

Yes. The .pc files are already correct: INIReader.pc already requires inih.pc...

[neheb]

Right.

/me doesn't understand cmake files. Or any advantages over pkgconfig.

[kmilos]

Let's maybe merge this tweak for now, and handle Findinih.cmake later eventually. Thanks.

[kmilos]

@mergify backport 0.28.x

[mergify]

backport 0.28.x

✅ Backports have been created

• #3030 libINIReader depends on libinih, the order is important when these libraries are static libraries (backport #3024) has been created for branch 0.28.x but encountered conflicts