apply correct aspectRatio when faceDetection fails to find face (#196)

FluidGroup · Mar 23, 2023 · 433b0b0 · 433b0b0
1 parent 34b1a45
commit 433b0b0
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/Sources/BrightroomEngine/Core/EditingStack.CropModifier.swift b/Sources/BrightroomEngine/Core/EditingStack.CropModifier.swift
@@ -40,22 +40,31 @@ extension EditingStack {
 
     public static func faceDetection(paddingBias: CGFloat = 1.3, aspectRatio: PixelAspectRatio? = nil) -> Self {
       return .init { image, crop, completion in
+
+        var fallbackCrop: EditingCrop {
+          guard let aspectRatio = aspectRatio else {
+            return crop
+          }
+          var new = crop
+          new.updateCropExtentIfNeeded(toFitAspectRatio: aspectRatio)
+          return new
+        }
 
         let request = VNDetectFaceRectanglesRequest { request, error in
 
           if let error = error {
             EngineLog.debug(error)
-            completion(crop)
+            completion(fallbackCrop)
             return
           }
 
           guard let results = request.results as? [VNFaceObservation] else {
-            completion(crop)
+            completion(fallbackCrop)
             return
           }
 
           guard let first = results.first else {
-            completion(crop)
+            completion(fallbackCrop)
             return
           }