Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Symfony 6 support. #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iisisrael
Copy link

Co-authored-by: Aaron Opela [email protected]

@iisisrael
Copy link
Author

If keeping support for older PHP versions is important, we can instead add checks for method exists, adding deprecation messages. It's only a concern in tests (Assert::assertMatchesRegularExpression()).

@GuilhemN
Copy link
Member

GuilhemN commented Nov 13, 2022

Do you have a strong use case for this? A legacy app that you cannot easily update?

This library is not really maintained anymore I'd say, last update is from 2021.

If you can, I would rather suggest to move your app to a different OAuth client (see https://oauth.net/code/php/ for some examples), and we probably should consider deprecating this library.

@GuilhemN
Copy link
Member

Probably decision here should be synced with FriendsOfSymfony/FOSOAuthServerBundle#698.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants