Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the reactivity - should be a sum of two channels, not a mean. #2889

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions bluemira/plasma_physics/reactions.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,8 @@
DOI 10.1088/0029-5515/32/4/I07
"""
if reaction == Reactions.D_D:
return 0.5 * (
_reactivity_bosch_hale(temp_kev, Reactions.D_D1)
+ _reactivity_bosch_hale(temp_kev, Reactions.D_D2)
return _reactivity_bosch_hale(temp_kev, Reactions.D_D1) + _reactivity_bosch_hale(

Check warning on line 370 in bluemira/plasma_physics/reactions.py

View check run for this annotation

Codecov / codecov/patch

bluemira/plasma_physics/reactions.py#L370

Added line #L370 was not covered by tests
temp_kev, Reactions.D_D2
)
mapping = {
Reactions.D_T: BoschHale_DT_4Hen(),
Expand Down