Add VerticalFieldConstraint and function to estimate plasma equilibrium field
#3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoronelBuendia
added
equilibria
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3076 +/- ##
===========================================
+ Coverage 79.74% 79.79% +0.04%
===========================================
Files 227 227
Lines 25451 25465 +14
===========================================
+ Hits 20297 20320 +23
+ Misses 5154 5145 -9 ☔ View full report in Codecov by Sentry. |
|
je-cook
reviewed
Mar 15, 2024
| is almost certainly irrelevant at the end of breakdown. | ||
| """ | ||
| k_term = 1.0 if kappa_95 is None else np.sqrt(2.0 / (1.0 + kappa_95**2)) | ||
| return -MU_0_4PI * I_p / R_0 * (beta_p_th + 0.5 * l_i - 1.5 + np.log(8 * A * k_term)) |
There was a problem hiding this comment.
Could we have a couple line test for this to an expected result?
There was a problem hiding this comment.
I agree, could you add a test to test_rules_of_thumb?
geograham
reviewed
Mar 18, 2024
| Thermal poloidal beta | ||
| l_i: | ||
| Normalised internal inductance | ||
| kappa: |
| is almost certainly irrelevant at the end of breakdown. | ||
| """ | ||
| k_term = 1.0 if kappa_95 is None else np.sqrt(2.0 / (1.0 + kappa_95**2)) | ||
| return -MU_0_4PI * I_p / R_0 * (beta_p_th + 0.5 * l_i - 1.5 + np.log(8 * A * k_term)) |
There was a problem hiding this comment.
I agree, could you add a test to test_rules_of_thumb?
je-cook
force-pushed
the
develop
branch
5 times, most recently
from
5a50acb
to
7574352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #{ID}
Description
Interface Changes
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build