Shellcraft stackargs #2219
Merged
Shellcraft stackargs #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo in the generated syscall template causing only the last stack argument to be generated. $ shellcraft -f asm mips.linux.sendto 3 0x123456 0x100 0 0xabcdefff 0x10 The 0xabcdefff argument was missing.
There are syscalls with 6 arguments like mmap and sendto which couldn't be called with all 6 arguments set. $ shellcraft -f asm mips.linux.mmap2 0 0x1000 'PROT_READ | PROT_WRITE | PROT_EXEC' 'MAP_PRIVATE | MAP_ANONYMOUS' -1 0
The `syscalls` variable is only present in the generate.py, not the generated template.
The mips.linux.syscall template was only handling 4 syscall arguments and silently discarded the remaining ones. Push the arguments to the stack instead. $ shellcraft -f asm mips.linux.syscall SYS_sendto 3 0x123456 0x100 0 0xabcdefff 0x10 Fixes Gallopsled#2153
|
Yes, of course. I didn't have time to test the last one concerning MIPS syscalls with > 4 arguments and forgot about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recently made bugfix that closes #2153; @peace-maker are you okay with Pwntools getting these changes?