Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Mac OS Install Documentation #2392

Merged
merged 4 commits into from
Apr 21, 2024
Merged

Conversation

lewiswatson55
Copy link
Contributor

Updated the documentation for installing Pwntools on Mac OS.

Firstly, Homebrew no longer supports direct references for brew install "for security reasons". Simple enough fix, just wget the correct .rb and then install from file.

Second issue, there were two requirements missing that had to be installed before I could pip install Pwntools - cmake and pkg-config. I'm coming from a new/fresh set up MacBook Pro, which didn't have either of these installed and I can't see any mention of them in the documentation.

Due to security reasons Homebrew has removed direct formula references, this is the workaround.
@peace-maker
Copy link
Member

Thank you! Just for clarification - this for a M1 chip MacBook Pro? There were several people having trouble installing pwntools on the Discord recently.

I don't think we need entries in the changelog for changes to the documentation? @Arusekk

@lewiswatson55
Copy link
Contributor Author

lewiswatson55 commented Apr 18, 2024

M3, I assume the point is more so that it's Apple Silicone :)

Edit: Checked with my M1 Mac mini, same issue/fix

@peace-maker
Copy link
Member

Can you revert the changes to the CHANGELOG.md please? I can't push to your fork due to duplicate dev branch problems and me not wanting to work around this :P

@lewiswatson55
Copy link
Contributor Author

All done

@peace-maker peace-maker merged commit d2a02a7 into Gallopsled:dev Apr 21, 2024
7 checks passed
@peace-maker
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants