Fix parsing the PLT on Windows #2445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer catching the ImportError to checking for W32 explicitly, since other exotic platforms might also be missing MAP_ANON or other things here and otherwise work correctly; I generally think it is better to test for features rather than platforms (see MDN: Don't browser sniff). |
|
Yup, you're right |
|
This should target stable since that 1GB allocation is in there too. |
The Unicorn Engine 1GB workaround doesn't work since `mmap` has different semantics on Windows.
peace-maker
force-pushed
the
plt_windows
branch
from
177c900
to
184b218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Unicorn Engine 1GB workaround doesn't work since
mmaphas different semantics on Windows.