Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed x86 GAS options #2449

Closed
wants to merge 1 commit into from
Closed

Fixed x86 GAS options #2449

wants to merge 1 commit into from

Conversation

9x14S
Copy link

@9x14S 9x14S commented Aug 22, 2024

I fixed the word size options accepted by GAS for the x86 architecture from -32/-64 to --32/--64.

Source:
https://sourceware.org/binutils/docs/as/i386_002dOptions.html

@peace-maker
Copy link
Member

Thank you for your contribution! GAS uses getopt_long_only to parse argv and thus supports - as well as -- for long options, so this isn't necessary. Did you encounter problems with some as version with different behavior?

I don't think this change helps code readability if it's only to align with the documentation.

@9x14S
Copy link
Author

9x14S commented Aug 22, 2024

I didn't have any issues with the assembler, I just noticed that and thought it was a bug.

Thanks for your reply! Guess I'll close this PR then.

@9x14S 9x14S closed this Aug 22, 2024
@peace-maker
Copy link
Member

Thank you for your help though, please come again if you notice something else 👍

@9x14S 9x14S deleted the stable branch August 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants