Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crux-mir improvements for Ring verification #960

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

spernsteiner
Copy link
Contributor

This branch includes a few crux-mir improvements used in the Ring SHA256 verification:

  • Add a macro for defining MethodSpecs. This automates the manual copy/paste we previously used for converting test cases to MethodSpecs.
  • Implement Symbolic trait for larger array sizes and for Wrapping<T>
  • Extend mem::transmute to support splitting and merging integers (for example, converting u32 to/from [u8; 4])
  • Update the mir-json submodule with allow changing crux-mir binary path using CRUX_MIR env var mir-json#21, which makes it easier to run crux-mir-comp (needed for the Ring proof)

@RyanGlScott
Copy link
Contributor

I haven't taken a close look at this since I don't feel like I'm qualified to review this in depth, but do let us know if you're blocked on a review, @spernsteiner.

plredmond and others added 7 commits August 24, 2022 13:53
…plements the `id` function and therefore a wrong result
…ect 0 ...` is LSB but the left argument to `BVConcat` is MSB

    impl 8   bv = bv
    impl bvw bv = let
        xsw = bvw - 8
        x  = BVSelect 0 8   bvw bv
        xs = BVSelect 8 xsw bvw bv
        in BVConcat 8 xsw x (impl xsw xs)
[crux-mir] Implement bswap intrinsic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants