Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binja: explicitly specify expected platform for pate container #412

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

thebendavis
Copy link
Member

Match platform in Dockerfile, avoid platform mismatch warning on non-native platforms (e.g. arm64 macs)

Match platform in Dockerfile, avoid platform mismatch warning on non-native platforms (e.g. arm64 macs)
@thebendavis thebendavis self-assigned this Jun 21, 2024
@thebendavis thebendavis removed the request for review from jim-carciofini June 21, 2024 16:45
@thebendavis thebendavis marked this pull request as draft June 21, 2024 16:45
@thebendavis thebendavis marked this pull request as ready for review June 21, 2024 17:00
Copy link
Collaborator

@jim-carciofini jim-carciofini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Same docker arg I used for MCAD.

@jim-carciofini jim-carciofini merged commit 9528e28 into master Jun 21, 2024
2 checks passed
@thebendavis thebendavis deleted the bd/binja-specify-pate-docker-platform branch July 11, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants