fix: allow loop creds to be empty if not enabled

[openoms]

moved from #1733

[openoms]

this should be part of service validation

copied from #1733 (comment)

[ntheile]

i did not think we were allowed to call process.env from any other file other than process.ts? should i just set it to blank if it does not exist and then in the loopservice i can validate?

[openoms]

probably here should be the validation, also service should not throw exceptions. Please check onchain service as example

copied from #1733 (comment)

[bodymindarts]

This should not ever happen - either config is set and tlsCert is never null or it is not set and this code should never be called see eab6cd4

[bodymindarts]

I have added a commit eab6cd4 that throws in the config if we try to access the loop config in the event that enabledSwap = false... it should never be called so we can flag the error right there.

[ntheile]

Yeah this commit looks good and makes sense.

I am still having trouble getting tests to run locally when testing this change, similar error to the e2e test TypeError: Cannot read properties of undefined (reading 'tracingServiceName')

[openoms]

I am still having trouble getting tests to run locally when testing this change, similar error to the e2e test TypeError: Cannot read properties of undefined (reading 'tracingServiceName')

Not sure why the tracingConfig came in the picture here, but ce26a65 lets the tests pass.

[ntheile]

i tested it and it works locally now. i would defer to @bodymindarts about the tracing config

[ntheile]

I created a custom docker image of this commit and it works with signet on my local dev charts node! Here is the config I set:

dev/galoy/galoy-signet-values.yml

galoy:
  network: signet
  images:
    ## Custom Test Galoy Application Image details
    app:
      repository: ntheile/galoy-test:0.0.9
      digest: "sha256:622984b81ad44d730666f1b95379978bf24156c540ec39e60ca1f9361db5dc8e"
      git_ref: "622984b"

  config:
    test_accounts:
      - ref: A
        phone: "INSERT_PHONE"
        code: "INSERT_CODE"
        role: "bankowner"
        username: "bankowner"
        ref: "bankowner"
        needUsdWallet: true
    apollo:
      playground: true
    cronConfig:
      swapEnabled: false

     ....