Show "Settings" link only for enabled plugins #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to be able to change settings even if the plugin is disabled. It should be a simple page for basic settings. What kind of overrides do you need in onBeginRequest for the settings page? |
|
At onBeginRequest I importing custom models, checking and adding to database nonexistence settings. |
|
Changing the settings of disabled plugin - seems strange to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it will be good to hide settings link for disabled plugins, because some plugins "runSettings" action can't work properly without overrides (from this plugin) for onBeginRequest