Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing client build dependency in Fedora. #5147

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Moxie07
Copy link

@Moxie07 Moxie07 commented Jul 28, 2024

What

Add missing client build dependency in Fedora Linux.

Why

Because when i tried to build it after installing the dependency showed in document, meson gives me the following error:
app/meson.build:115:20: ERROR: Dependency "libavdevice" not found, tried pkgconfig

How

Add libavdevice-free-devel package.

Where

Fedora Linux 40, KDE Plasma.

@rom1v
Copy link
Collaborator

rom1v commented Jul 31, 2024

Thank you for the PR.

Any reason why it is a draft?

@Moxie07
Copy link
Author

Moxie07 commented Jul 31, 2024

Thank you for the PR.

Any reason why it is a draft?

Because i need to see if this PR is worth enough to merge.
If the code is good enough to merge, then please merge.
If the code is not good enough to merge, then it is easier to discuss and revise the code.

@rom1v
Copy link
Collaborator

rom1v commented Jul 31, 2024

Could someone with Fedora confirm?

@Moxie07
Copy link
Author

Moxie07 commented Aug 11, 2024

I had tested the issue in Fedora 40 docker image and Fedora 40 KDE virtual machine. The result is:

  1. In Fedora 40 docker image, the build is successful without libavdevice-free-devel package installed.
  2. In Fedora 40 KDE virtual machine, the build is not successful without libavdevice-free-devel.

Conclusion is, this is a Fedora KDE issue, not Fedora in general.
Maybe we can add it just in case?

@Moxie07
Copy link
Author

Moxie07 commented Aug 11, 2024

The dockerfile is:

# Add Fedora linux, the target platform.
FROM fedora:40
RUN ls -l
# Install git.
RUN sudo dnf install git -y
# Clone scrcpy repository.
RUN git clone https://github.com/Genymobile/scrcpy.git
WORKDIR /scrcpy/
RUN ls -l
RUN sudo dnf install wget -y
# Download scrcpy prebuilt-server.
RUN wget https://github.com/Genymobile/scrcpy/releases/download/v2.6.1/scrcpy-server-v2.6.1
RUN sudo dnf install ninja-build -y
RUN sudo dnf install https://download1.rpmfusion.org/free/fedora/rpmfusion-free-release-$(rpm -E %fedora).noarch.rpm -y
RUN sudo dnf install SDL2-devel ffms2-devel libusb1-devel meson gcc make -y
RUN meson setup x --buildtype=release --strip -Db_lto=true -Dprebuilt_server=./scrcpy-server-v2.6.1
# DO NOT RUN AS ROOT
RUN ninja -Cx

@elvisisvan
Copy link

elvisisvan commented Sep 9, 2024

mine is fedora 38 kde plasma, same missing dependency error for libavdevice and libavformat and sdl2, if i install one then the other must be uninstalled, this is a dilemma

libavformat

libavdevice

sdl2

package-conflicts

commit: v2.6.1 44b3fd8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants