Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v15 #130

Merged
merged 16 commits into from
Jul 16, 2024
Merged

v15 #130

merged 16 commits into from
Jul 16, 2024

Conversation

BotellaA
Copy link
Member

No description provided.

@BenoitTHEBAULT BenoitTHEBAULT requested review from BenoitTHEBAULT and removed request for BenoitTHEBAULT July 16, 2024 08:07
BenPinet and others added 2 commits July 16, 2024 10:09
@BenPinet
fix(Deprecated): remove deprecated methods
fd29f2f 
BREAKING CHANGE: remove deprecated copy methods
@MelchiorSchuh
Merge pull request #131 from Geode-solutions/fix/remove-deprecated
45566a5 
fix(Deprecated): remove deprecated methods
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

BotellaA and others added 4 commits July 16, 2024 12:23
@BotellaA
fix(Headers): change extension convention from .h to .hpp
878a53a 
BREAKING CHANGE: rename all extensions from .h to.hpp
@BotellaA @github-actions
Apply prepare changes
20f04d5
@BotellaA
update bindings
3e7e6ca
@MelchiorSchuh
Merge pull request #132 from Geode-solutions/fix/headers
bd1d440 
fix(Headers): change extension convention from .h to .hpp
github-actions[bot]
github-actions bot reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 64. Check the log or trigger a new build to see more.

src/geode/geosciences/explicit/common.cpp
@@ -21,17 +21,17 @@
*
*/

#include <geode/basic/common.h>
#include <geode/basic/logger.h>
#include <geode/basic/common.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/basic/common.hpp' file not found [clang-diagnostic-error]

#include <geode/basic/common.hpp>
         ^

src/geode/geosciences/explicit/geometry/geographic_coordinate_system.cpp
@@ -21,15 +21,15 @@
*
*/

#include <geode/geosciences/explicit/geometry/geographic_coordinate_system.h>
#include <geode/geosciences/explicit/geometry/geographic_coordinate_system.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/geometry/geographic_coordinate_system.hpp' file not found [clang-diagnostic-error]

 SOFTWARE.
                                ^

src/geode/geosciences/explicit/geometry/geographic_coordinate_system_helper.cpp
@@ -21,30 +21,30 @@
*
*/

#include <geode/geosciences/explicit/geometry/geographic_coordinate_system_helper.h>
#include <geode/geosciences/explicit/geometry/geographic_coordinate_system_helper.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/geometry/geographic_coordinate_system_helper.hpp' file not found [clang-diagnostic-error]

 SOFTWARE.
                                ^

src/geode/geosciences/explicit/mixin/builder/fault_blocks_builder.cpp
@@ -21,10 +21,10 @@
*
*/

#include <geode/geosciences/explicit/mixin/builder/fault_blocks_builder.h>
#include <geode/geosciences/explicit/mixin/builder/fault_blocks_builder.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/mixin/builder/fault_blocks_builder.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/mixin/builder/fault_blocks_builder.hpp>
         ^

src/geode/geosciences/explicit/mixin/builder/faults_builder.cpp
@@ -21,10 +21,10 @@
*
*/

#include <geode/geosciences/explicit/mixin/builder/faults_builder.h>
#include <geode/geosciences/explicit/mixin/builder/faults_builder.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/mixin/builder/faults_builder.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/mixin/builder/faults_builder.hpp>
         ^

src/geode/geosciences/explicit/representation/core/structural_model.cpp
@@ -21,12 +21,12 @@
*
*/

#include <geode/geosciences/explicit/representation/core/structural_model.h>
#include <geode/geosciences/explicit/representation/core/structural_model.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/core/structural_model.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/core/structural_model.hpp>
         ^

src/geode/geosciences/explicit/representation/io/cross_section_input.cpp
@@ -21,19 +21,19 @@
*
*/

#include <geode/geosciences/explicit/representation/io/cross_section_input.h>
#include <geode/geosciences/explicit/representation/io/cross_section_input.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/cross_section_input.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/cross_section_input.hpp>
         ^

src/geode/geosciences/explicit/representation/io/cross_section_output.cpp
@@ -21,19 +21,19 @@
*
*/

#include <geode/geosciences/explicit/representation/io/cross_section_output.h>
#include <geode/geosciences/explicit/representation/io/cross_section_output.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/cross_section_output.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/cross_section_output.hpp>
         ^

src/geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.cpp
@@ -21,26 +21,26 @@
*
*/

#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.h>
#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.hpp>
         ^

src/geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.cpp
@@ -21,7 +21,7 @@
*
*/

#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.h>
#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.hpp>
         ^

@BotellaA BotellaA marked this pull request as ready for review July 16, 2024 19:12
github-actions[bot]
github-actions bot reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 39. Check the log or trigger a new build to see more.

src/geode/geosciences/explicit/representation/io/geode/geode_structural_model_input.cpp
@@ -21,28 +21,28 @@
*
*/

#include <geode/geosciences/explicit/representation/io/geode/geode_structural_model_input.h>
#include <geode/geosciences/explicit/representation/io/geode/geode_structural_model_input.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/geode/geode_structural_model_input.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/geode/geode_structural_model_input.hpp>
         ^

src/geode/geosciences/explicit/representation/io/geode/geode_structural_model_output.cpp
@@ -21,7 +21,7 @@
*
*/

#include <geode/geosciences/explicit/representation/io/geode/geode_structural_model_output.h>
#include <geode/geosciences/explicit/representation/io/geode/geode_structural_model_output.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/geode/geode_structural_model_output.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/geode/geode_structural_model_output.hpp>
         ^

src/geode/geosciences/explicit/representation/io/structural_model_input.cpp
@@ -21,19 +21,19 @@
*
*/

#include <geode/geosciences/explicit/representation/io/structural_model_input.h>
#include <geode/geosciences/explicit/representation/io/structural_model_input.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/structural_model_input.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/structural_model_input.hpp>
         ^

src/geode/geosciences/explicit/representation/io/structural_model_output.cpp
@@ -21,19 +21,19 @@
*
*/

#include <geode/geosciences/explicit/representation/io/structural_model_output.h>
#include <geode/geosciences/explicit/representation/io/structural_model_output.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/structural_model_output.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/structural_model_output.hpp>
         ^

src/geode/geosciences/implicit/common.cpp
@@ -21,15 +21,15 @@
*
*/

#include <geode/geosciences/explicit/common.h>
#include <geode/geosciences/explicit/common.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/common.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/common.hpp>
         ^

src/geode/geosciences/implicit/representation/io/geode/geode_implicit_cross_section_output.cpp
@@ -21,7 +21,7 @@
*
*/

#include <geode/geosciences/implicit/representation/io/geode/geode_implicit_cross_section_output.h>
#include <geode/geosciences/implicit/representation/io/geode/geode_implicit_cross_section_output.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/representation/io/geode/geode_implicit_cross_section_output.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/representation/io/geode/geode_implicit_cross_section_output.hpp>
         ^

...geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_input.cpp
@@ -21,23 +21,23 @@
*
*/

#include <geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_input.h>
#include <geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_input.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_input.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_input.hpp>
         ^

...eode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_output.cpp
@@ -21,7 +21,7 @@
*
*/

#include <geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_output.h>
#include <geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_output.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_output.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_output.hpp>
         ^

src/geode/geosciences/implicit/representation/io/horizons_stack_input.cpp
@@ -21,18 +21,18 @@
*
*/

#include <geode/geosciences/implicit/representation/io/horizons_stack_input.h>
#include <geode/geosciences/implicit/representation/io/horizons_stack_input.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/representation/io/horizons_stack_input.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/representation/io/horizons_stack_input.hpp>
         ^

src/geode/geosciences/implicit/representation/io/horizons_stack_output.cpp
@@ -21,17 +21,17 @@
*
*/

#include <geode/geosciences/implicit/representation/io/horizons_stack_output.h>
#include <geode/geosciences/implicit/representation/io/horizons_stack_output.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/representation/io/horizons_stack_output.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/representation/io/horizons_stack_output.hpp>
         ^

@MelchiorSchuh MelchiorSchuh merged commit 84db231 into next Jul 16, 2024
31 checks passed
@panquez
Copy link
Member

panquez commented Jul 16, 2024

🎉 This PR is included in version 8.0.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@panquez
Copy link
Member

panquez commented Jul 17, 2024

🎉 This PR is included in version 8.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA BotellaA deleted the v15 branch July 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BotellaA @panquez @MelchiorSchuh @BenPinet