Update contributor details (#494)

* Update contributor details * Update favicon * Add handling of bs5 alongside bs4 * Bump version to 2.3.1 --------- Co-authored-by: delsim <[email protected]>
GibbsConsulting · Mar 28, 2024 · 7507f2a · 7507f2a
1 parent 83d37fa
commit 7507f2a
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/CONTRIBUTIONS.md b/CONTRIBUTIONS.md
@@ -18,7 +18,7 @@ Thanks to the following people:
 
 [weber-s](https://github.com/weber-s)
 
-[eddy-obj](https://github.com/eddy-ojb)
+[eddyojb88](https://github.com/eddyojb88)
 
 [brylie](https://github.com/brylie)
 
@@ -61,3 +61,4 @@ Thanks to the following people:
 [erl987](https://github.com/erl987)
 
 [funkyrailroad](https://github.com/funkyrailroad)
+
diff --git a/demo/demo/static/demo/favicon.png b/demo/demo/static/demo/favicon.png
diff --git a/demo/demo/templates/base.html b/demo/demo/templates/base.html
@@ -8,6 +8,7 @@
    {% bootstrap_javascript jquery="full"%}
    {% block extra_header%}{% endblock%}
    {% block app_header_css%}
+   <link rel="shortcut icon" href="{% static 'demo/favicon.png' %}" type="image/x-icon"></link>
    <link rel="stylesheet" type="text/css" href="{%static "demo/demo.css"%}"></link>
    {% endblock%}
    {% plotly_header%}

diff --git a/django_plotly_dash/dash_wrapper.py b/django_plotly_dash/dash_wrapper.py
@@ -191,8 +191,12 @@ def __init__(self, name=None, serve_locally=None,
         self._suppress_callback_exceptions = suppress_callback_exceptions
 
         if add_bootstrap_links:
-            from bootstrap4.bootstrap import css_url
-            bootstrap_source = css_url()['href']
+            try:
+                from bootstrap4.bootstrap import css_url
+                bootstrap_source = css_url()['href']
+            except:
+                from django_bootstrap5.core import css_url
+                bootstrap_source = css_url()['url']
 
             if self._serve_locally:
                 # Ensure package is loaded; if not present then pip install dpd-static-support

diff --git a/django_plotly_dash/version.py b/django_plotly_dash/version.py
@@ -23,4 +23,4 @@
 
 '''
 
-__version__ = "2.3.0"
+__version__ = "2.3.1"