feat: adds support to multi-level submodule #2610
Open
+88
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
@bharathkkb FYI: This is for compatibility with repo like https://github.com/GoogleCloudPlatform/terraform-google-enterprise-application |
|
/gcbrun |
amandakarina
requested review from
bharathkkb,
g-awmalik and
apeabody
as code owners
| source = "terraform-google-modules/example-with-steps-submodules/google" | ||
| version = "~> 3.2.0" | ||
|
|
||
| project_id = var.project_id # Replace this with your project ID in quotes |
There was a problem hiding this comment.
Based on the comment # Replace this with your project ID in quotes I'm wondering if the best approach would be to hardcode the project_id on the main.tf or keep the it as it is (variables) and add the value into a terraform.tfvars file.
There was a problem hiding this comment.
Thanks @renato-rudnicki - This is testdata, and this particular field isn't actually critical to the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to sub-modules in structure:
terraform-google-modules/example/step/module/bar-module