Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: Move tests into dirs #1675

Merged
merged 19 commits into from
Apr 19, 2024
Merged

Internal: Move tests into dirs #1675

merged 19 commits into from
Apr 19, 2024

Conversation

Subbarker
Copy link
Contributor

@Subbarker Subbarker commented Apr 15, 2024 •
edited
Loading

Description

This is because gotestsum breaks in odd ways when we don't have test directories.

Related issue

b/330174886

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@Subbarker Subbarker added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 15, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 15, 2024
@Subbarker Subbarker added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 15, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 15, 2024
@Subbarker Subbarker added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 15, 2024
@Subbarker Subbarker marked this pull request as ready for review April 15, 2024 17:39
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 15, 2024
martijnvans
martijnvans reviewed Apr 17, 2024
View reviewed changes
integration_test/third_party_apps_test/main_test.go Outdated Show resolved Hide resolved
kokoro/scripts/test/go_test.sh Outdated Show resolved Hide resolved
integration_test/third_party_apps_test/main_test.go Outdated Show resolved Hide resolved
integration_test/third_party_apps_test/main_test.go Outdated Show resolved Hide resolved
@martijnvans martijnvans merged commit d49914e into master Apr 19, 2024
67 of 68 checks passed
@martijnvans martijnvans deleted the subbarker-tests-dirs branch April 19, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvans martijnvans martijnvans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Subbarker @martijnvans @stackdriver-instrumentation-release