Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Add A3/H100 to the GPU nvml/dcgm tests #1725

Merged
merged 9 commits into from
Sep 18, 2024
Merged

[Testing] Add A3/H100 to the GPU nvml/dcgm tests #1725

merged 9 commits into from
Sep 18, 2024

Conversation

LujieDuan
Copy link
Contributor

@LujieDuan LujieDuan commented May 28, 2024 •
edited
Loading

Description

Add A3 (with H100 80GB GPUs) to the NVML and DCGM integration tests.

Due to quota constraints, the A3 tests only run in nightlies (on ubuntu-os-cloud:ubuntu-minimal-2004-lts).

Related issue

b/296048457

How has this been tested?

Temporarily changed the presubmit to run on ubuntu-os-cloud:ubuntu-minimal-2004-lts and the tests were passing.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@LujieDuan

This comment was marked as resolved.

Sign in to view
@LujieDuan LujieDuan changed the title Add A3/H100 to the nvml test Add A3/H100 to the GPU nvml/dcgm tests Jul 3, 2024
@LujieDuan LujieDuan changed the title Add A3/H100 to the GPU nvml/dcgm tests [Testing] Add A3/H100 to the GPU nvml/dcgm tests Sep 17, 2024
@LujieDuan LujieDuan marked this pull request as ready for review September 17, 2024 15:33
igorpeshansky
igorpeshansky reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

integration_test/third_party_apps_test/applications/dcgm/metadata.yaml Outdated Show resolved Hide resolved
integration_test/third_party_apps_test/applications/nvml/metadata.yaml Outdated Show resolved Hide resolved
integration_test/third_party_apps_test/main_test.go Outdated Show resolved Hide resolved
igorpeshansky
igorpeshansky approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@LujieDuan LujieDuan merged commit 99cd60a into master Sep 18, 2024
57 of 60 checks passed
@LujieDuan LujieDuan deleted the lujieduan-add-h100 branch September 18, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LujieDuan @igorpeshansky