Refactor archive #38
Open
Refactor archive #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J164
changed the title
AydanPirani
reviewed
Sep 9, 2024
Comment on lines
+26
to
+34
| useEffect(() => { | ||
| const fetchTeamData = async () => { | ||
| const response = await fetch(`/team/data/${year}.json`); | ||
| const data = await response.json(); | ||
| setTeam(data); | ||
| }; | ||
|
|
||
| fetchTeamData(); | ||
| }, [year]); |
There was a problem hiding this comment.
this can just be fixed by importing json
There was a problem hiding this comment.
import staffInfo from '../info/staff-info.json';
There was a problem hiding this comment.
Do we want one large json file that contains the staff info for every year then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the new year's team involves four steps:
<year>.jsonto/public/team/data/public/team/photos/<year>/yearsarray incomponents/Team/Team.tsxcomponents/Team/Team.tsxto new year