Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added messages for access control rejection messages #2606

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Jan 9, 2023

This provides message strings for the extended reject reasons, including HTTP-adopted codes.

@codecov-commenter
Copy link

Codecov Report

Merging #2606 (f14c349) into master (41c4b1f) will increase coverage by 0.24%.
The diff coverage is 79.24%.

@@            Coverage Diff             @@
##           master    #2606      +/-   ##
==========================================
+ Coverage   66.46%   66.70%   +0.24%     
==========================================
  Files          99       99              
  Lines       19826    19875      +49     
==========================================
+ Hits        13177    13258      +81     
+ Misses       6649     6617      -32     
Impacted Files Coverage Δ
srtcore/srt.h 100.00% <ø> (ø)
srtcore/srt_c_api.cpp 46.04% <67.64%> (+5.71%) ⬆️
srtcore/core.cpp 61.84% <100.00%> (+1.12%) ⬆️
test/test_listen_callback.cpp 91.59% <100.00%> (+2.70%) ⬆️
srtcore/api.cpp 53.22% <0.00%> (-1.76%) ⬇️
srtcore/buffer_snd.cpp 68.06% <0.00%> (-0.65%) ⬇️
srtcore/queue.cpp 80.73% <0.00%> (+0.29%) ⬆️
srtcore/congctl.cpp 82.90% <0.00%> (+0.51%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [API] Area: Changes in SRT library API labels Jan 10, 2023
@ethouris ethouris marked this pull request as ready for review January 12, 2023 12:38
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Feb 9, 2023
@maxsharabayko maxsharabayko modified the milestones: v1.5.4, v1.6.0 Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[API] Area: Changes in SRT library API Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants