Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash Screen and Starter Requirements added REACT NATIVE #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Shishir198
Copy link

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Fixes # [ISSUE]

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface
  • Documentation

Screenshots

Added later in Comments

Checklist:

  • [y ] My code follows the style guidelines(Clean Code) of this project
  • [ y] I have performed a self-review of my own code
  • [ y] I have commented my code, particularly in hard-to-understand areas
  • [y ] I have added tests/screenshots(If any) that prove my fix is effective or that my feature works

@Shishir198
Copy link
Author

WhatsApp Image 2020-08-19 at 4 13 28 AM

@Shishir198
Copy link
Author

@helios1101 Kindly help I am unable to understand What all checks have failed.Please guide me through this

@helios1101
Copy link
Collaborator

helios1101 commented Aug 19, 2020

Hi @Shishir198
There are basic code indention checks, and will be automatically be corrected by the bot.
Focus on functionality, rest the bot will take care.
Also, can you add the video of splash screen as weel ?
The bot PR will be mergerd, but points will be awarded to you only.
Hope this helps :)

@Shishir198
Copy link
Author

@helios1101 okay this sounds good sir,
In the context of video - Actually I had Just presented the code asylum logo image as the splash screen
just like YouTube App does.
In Live,
It will show that still image for few secs and then the inner components like youtube.

Is anything extra required from my side in splash screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants