Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed websocket support in hs.httpserver:start() #3665

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed websocket support in hs.httpserver:start() #3665

wants to merge 2 commits into from

Conversation

latenitefilms
Copy link
Contributor

github-actions[bot]
github-actions bot requested changes Aug 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@latenitefilms latenitefilms added the pr-fix Pull Request implementing a bug fix label Aug 10, 2024
cmsj
cmsj requested changes Aug 11, 2024
View reviewed changes
extensions/httpserver/libhttpserver.m Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.70%. Comparing base (ec9a8ea) to head (45eaf01).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3665      +/-   ##
==========================================
+ Coverage   27.65%   27.70%   +0.04%     
==========================================
  Files         191      191              
  Lines       43472    43528      +56     
==========================================
+ Hits        12023    12059      +36     
- Misses      31449    31469      +20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmsj cmsj cmsj requested changes

@github-actions GitHub Actions github-actions approved these changes

@asmagill asmagill Awaiting requested review from asmagill

Assignees
No one assigned
Labels
pr-fix Pull Request implementing a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is an HTTP callback required if I only want a WebSocket server in hs.httpserver?
2 participants
@latenitefilms @cmsj