Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new methods for core-app-cli #171

Merged
merged 13 commits into from
Oct 30, 2023
Merged

add new methods for core-app-cli #171

merged 13 commits into from
Oct 30, 2023

Conversation

JettTech
Copy link
Contributor

No description provided.

@JettTech JettTech requested a review from zo-el as a code owner October 19, 2023 05:33
zo-el
zo-el reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we start combining all the HHA types into one crate here (apart from the DNA itself)? it is going to start getting hard to maintain.

zo-el
zo-el previously approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else looks good

@zo-el zo-el changed the title add new methods add new methods for core-app-cli Oct 30, 2023
@JettTech JettTech requested a review from zo-el October 30, 2023 15:52
@zo-el zo-el merged commit 1eb51b7 into main Oct 30, 2023
2 checks passed
@zo-el zo-el deleted the feaature/add-set-prefs-endpoint branch October 30, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zo-el zo-el zo-el approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JettTech @zo-el