Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ultdata: update livecheck, use versioned url #178600

Closed
wants to merge 1 commit into from

Conversation

khipp
Copy link
Member

@khipp khipp commented Jul 4, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Related to #171006.

@p-linnane p-linnane requested a review from samford July 5, 2024 18:06
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking in the app, it appears that 1053 is the product ID (there are strings like "ProductURL" = "http://cbs.tenorshare.com/go?pid=1053&a=dp"), so this approach may not be any more versioned than the existing URL.

If 1053 was a number that would change (e.g., a build number, etc.), I'm still not sure where we stand on using a version that doesn't include the app version. Usually we would use something like 9.7.27,1053 (or 9.7.27.12,1053) and version.csv.second in the url but that's not feasible since we can only identify the version using ExtractPlist.

It would be good for someone else to check my work but that's what I'm seeing from a quick look.

@chenrui333 chenrui333 added the livecheck Issues or PRs related to livecheck label Jul 5, 2024
@krehel
Copy link
Member

krehel commented Jul 5, 2024

Agreed with @samford. Read this yesterday, forgot to comment. I'm not in favor of this, sorry.

@khipp
Copy link
Member Author

khipp commented Jul 5, 2024

Agreed, I will close this one then. Thanks anyway!

@khipp khipp closed this Jul 5, 2024
@krehel
Copy link
Member

krehel commented Jul 5, 2024

No worries @khipp - it happens! Thanks for the contribution. ❤️

@khipp khipp deleted the update-ultdata branch July 5, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants