Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitdefender.app v2.3 #27540

Closed
wants to merge 2 commits into from
Closed

Add Bitdefender.app v2.3 #27540

wants to merge 2 commits into from

Conversation

dcondrey
Copy link
Contributor

@dcondrey dcondrey commented Dec 9, 2016

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked that the cask was not already refused in closed issues.

@dcondrey
Copy link
Contributor Author

dcondrey commented Dec 9, 2016

The dmg file contains a secondary uninstaller pkg which is not installed with the installer package, but seems to do a more thorough uninstall than what I wrote in the stanza. I'm not sure how to reference that secondary uninstall pkg though.

@miccal
Copy link
Member

miccal commented Dec 9, 2016

I'm not sure how to reference that secondary uninstall pkg though.

You can't at this stage - see discussion here.

@dcondrey
Copy link
Contributor Author

dcondrey commented Dec 9, 2016

I thought perhaps I could copy over the uninstall package as a post_install step but not sure.

@dcondrey
Copy link
Contributor Author

@fanquake Why the on hold tag?

@adidalal
Copy link
Contributor

Does the app fully uninstall? If not, we can't add it - that's why the tag, I believe.

@dcondrey
Copy link
Contributor Author

The app does uninstall successfully as is.

@miccal miccal removed the on hold label Dec 24, 2016

url 'http://download.bitdefender.com/mac/antivirus/en/bitdefender_antivirus_for_mac.dmg'
name 'Bitdefender Virus Scanner'
homepage 'http://www.bitdefender.com/solutions/virus-scanner-for-mac.html'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm this is the correct homepage? I get a 404 error, and going to http://www.bitdefender.com.au/solutions/antivirus-for-mac.html I need to enter an email address to download the trial, which is not the one downloaded via the url you provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The given homepage works just fine, testing with an American VPN, but as you said the .au version fails for me too. Maybe we should just make this http://www.bitdefender.com/?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But even from http://www.bitdefender.com/ I cannot find a link to the file in the original url?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this maybe a link to the paid version, then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcondrey any follow-up on this?

@miccal miccal added the awaiting user reply Issue needs response from a user. label Dec 24, 2016
@dcondrey
Copy link
Contributor Author

dcondrey commented Dec 31, 2016

All links on the website direct to the App Store but I found this direct link crawling around for it with a little help from Google.

@miccal
Copy link
Member

miccal commented Dec 31, 2016

Thanks @dcondrey - unfortunately, unless there is an easily verifiable link via the homepage, I do not think we can accept this.

@miccal miccal removed the awaiting user reply Issue needs response from a user. label Dec 31, 2016
@reitermarkus
Copy link
Member

I found it here: http://www.bitdefender.com/Downloads/

@miccal
Copy link
Member

miccal commented Dec 31, 2016

@reitermarkus those links do not download the .pkg referenced in the original PR - the .dmg contains a .pkg called Bitdefender_aa9d5ce5-7b01-4743-9eec-5480ce596363.pkg.

@reitermarkus
Copy link
Member

You're right, seems like the trial really is only a trial.

  • http://download.bitdefender.com/mac/av/en/bitdefender_antivirus_for_mac.dmg (15.1 MB)
  • http://download.bitdefender.com/mac/antivirus/en/bitdefender_antivirus_for_mac.dmg (171.4 MB)

@miccal
Copy link
Member

miccal commented Dec 31, 2016

Precisely.

@dcondrey
Copy link
Contributor Author

Downloaded this new one and it installs an obnoxious app called BitDefender Central which just seems to be an intermediary forcing me to create a user account.

@reitermarkus
Copy link
Member

The 171.4 MB one seems to be from 2012.

@miccal
Copy link
Member

miccal commented Dec 31, 2016

Ah, vintage!

@dcondrey
Copy link
Contributor Author

This Bitdefender software kinda seems to be it's own virus.. it takes up way too much space and resources. :/

@dcondrey dcondrey closed this Dec 31, 2016
@miccal
Copy link
Member

miccal commented Dec 31, 2016

Thank you for your efforts though @dcondrey, they are appreciated.

@dcondrey
Copy link
Contributor Author

dcondrey commented Jan 2, 2017

np

@dcondrey dcondrey deleted the bitdefender branch January 9, 2017 21:45
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants