Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add silent install for Adobe Creative Cloud #67745

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

danielbayley
Copy link
Contributor

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

@danielbayley danielbayley force-pushed the adobe-creative-cloud branch 7 times, most recently from f5d50de to 50478e5 Compare August 18, 2019 07:22
@danielbayley danielbayley changed the title Add silent install for Adobe Creative Cloud [WIP] Add silent install for Adobe Creative Cloud Aug 18, 2019
@reitermarkus reitermarkus merged commit f928253 into Homebrew:master Aug 19, 2019
@danielbayley
Copy link
Contributor Author

danielbayley commented Aug 19, 2019

This PR wasn't really ready to merge yet 😬 (why I marked it "[WIP]")… There will still be a lot of crap left over after uninstall, and even zap. I almost have the full list of items in my local fork (doing this now while I currently have to reinstall Creative Cloud)… @reitermarkus Can a PR be reopened?

@reitermarkus
Copy link
Member

Sorry, I totally missed the WIP.

Can a PR be reopened?

Not if it has been merged, please open a new one.

danielbayley added a commit to danielbayley/homebrew-cask that referenced this pull request Sep 13, 2019
Following on from Homebrew#67745, which was merged prematurely… this PR cleans up all of the leftover crap from Adobe CC.
vitorgalvao pushed a commit that referenced this pull request Sep 17, 2019
Following on from #67745, which was merged prematurely… this PR cleans up all of the leftover crap from Adobe CC.
danielbayley added a commit to danielbayley/homebrew-cask that referenced this pull request Sep 23, 2019
Following on from Homebrew#67745, which was merged prematurely… this PR cleans up all of the leftover crap from Adobe CC.
@lock lock bot added the outdated label Jan 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants