libphonenumber: use Homebrew abseil
#105800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
boost
SMillerDev
previously approved these changes
Jul 14, 2022
carlocab
force-pushed
the
libphonenumber-absl
branch
from
a4afb9e
to
c9f11a2
Compare
MikeMcQuaid
reviewed
Jul 14, 2022
carlocab
force-pushed
the
libphonenumber-absl
branch
from
c9f11a2
to
7595e1c
Compare
carlocab
commented
Jul 14, 2022
Formula/libphonenumber.rb
Outdated
| # We're not using the upstream patch because it doesn't work yet. | ||
| # https://github.com/google/libphonenumber/pull/2772#issuecomment-1184289820 | ||
| patch do | ||
| url "https://github.com/google/libphonenumber/commit/0774b63c844db93cfa85f79bd68021b335bea897.patch?full_index=1" |
This downloads its own `abseil` during the build, and then gets confused about where to find `abseil` headers when you try to link with it. Let's fix that by relying on our version of `abseil` instead. This should help unblock Homebrew#105712 and previous attempts to bump this formula's version (e.g. Homebrew#105188, Homebrew#101703, Homebrew#98994, Homebrew#96834).
carlocab
force-pushed
the
libphonenumber-absl
branch
from
7595e1c
to
12b16e7
Compare
|
Merging this to take advantage of a free |
|
Upstream has merged a version of the patch. Switching to it in #106194. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This downloads its own
abseilduring the build, and then gets confusedabout where to find
abseilheaders when you try to link with it.Let's fix that by relying on our version of
abseilinstead.This should help unblock #105712 and previous attempts to bump this
formula's version (e.g. #105188, #101703, #98994, #96834).